More fixes #29
Closed
More fixes #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 23 commits
July 11, 2025 15:08
This reverts commit 1c49397.
ryan-roemer
reviewed
Jul 16, 2025
ryan-roemer
reviewed
Jul 16, 2025
ryan-roemer
reviewed
Jul 16, 2025
ryan-roemer
reviewed
Jul 16, 2025
ryan-roemer
reviewed
Jul 16, 2025
|
Thanks sir! I'll add the character explicit split. The binary search thing
is a bit esoteric to me as well, honestly.
…On Tue, Jul 15, 2025, 7:14 PM Ryan Roemer ***@***.***> wrote:
***@***.**** commented on this pull request.
This is looking pretty good! Just minor suggestions mostly.
Big thing is the binary search vs. linear progression for character
splitting. Maybe I'm missing something? Let's chat if there's an
optimization and whether to do it here or in follow on work
—
Reply to this email directly, view it on GitHub
<#29 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE7IYMLJF7N7SUACHJNBXOL3IWYOZAVCNFSM6AAAAACBSRLQXOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTAMRSHA4DIMRVGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
I further analyzed the binary search when it comes to calculating where the overlap should begin. The performance is pretty dramatic. 
|
added 16 commits
July 17, 2025 10:45
|
As discussed with @mscottx88, we're still waiting for a round of reviews on this and a bit of discussion. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #28